Closed fatchat closed 6 months ago
@fatchat Please assign this issue to me.
@huzaifmalik786 just go ahead and submit a PR once you're ready i won't assign it to anyone
Understood
Sure, there is already a PR in progress but it hasn’t been completed yet
On Wed, 6 Mar 2024 at 11:49 PM, Rakshit @.***> wrote:
@fatchat https://github.com/fatchat Sir, Can I work on this issue?
— Reply to this email directly, view it on GitHub https://github.com/DalgoT4D/prefect-proxy/issues/104#issuecomment-1981516900, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQPOIEOYUKQF6IGPX624T3YW5M3PAVCNFSM6AAAAABDUZT2FKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBRGUYTMOJQGA . You are receiving this because you were mentioned.Message ID: @.***>
Description
Prefect is the orchestrator used by Dalgo. Prefect runs jobs using
flow-runs
andtask-runs
, the latter being sub-units of the former.Sometimes a user wants to cancel a flow-run which is running or queued to run. This PR provides a means for the Dalgo system to submit a cancellation request to Prefect
Goals
proxy/service.py
which takes aflow_run_id
and submits a cancellation request to PrefectExpected Outcome
The new function will take the ID of a running or queued flow-run and cancel it.
Acceptance Criteria
proxy/service.py
calledcancel_flow_run(flow_run_id: str)
tests/test_service.py
calledtest_cancel_flow_run
which tests this new functionImplementation Details
Use the same libraries as the rest of
prefect-proxy
. Cancellation method is described hereMockups / Wireframes
None required
Product Name
Dalgo
Project Name
Dalgo
Organization Name:
Project Tech4Dev
Domain
Others
Tech Skills Needed:
Python
Mentor(s)
@fatchat
Complexity
Medium
Category
Integrations, Feature
Sub Category
Backend