DalgoT4D / prefect-proxy

GNU Affero General Public License v3.0
1 stars 7 forks source link

dbt test failures caught #63

Closed fatchat closed 1 year ago

fatchat commented 1 year ago

Each dbt operation is now run within a Task

Stick to using dbt_op.run() rather than switching to .trigger() ... we catch any exceptions raised by the job and propagate them to the parent Flow, unless the job is a dbt test. Failures of dbt test are reported as successful Task completions

Also failures of all other steps are no longer suppressed... we catch them to log the error but then re-raise

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (b2c26e0) 91.28% compared to head (5a79d56) 91.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #63 +/- ## ======================================= Coverage 91.28% 91.28% ======================================= Files 2 2 Lines 838 838 ======================================= Hits 765 765 Misses 73 73 ``` | [Files Changed](https://app.codecov.io/gh/DevDataPlatform/prefect-proxy/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DevDataPlatform) | Coverage Δ | | |---|---|---| | [proxy/service.py](https://app.codecov.io/gh/DevDataPlatform/prefect-proxy/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DevDataPlatform#diff-cHJveHkvc2VydmljZS5weQ==) | `93.09% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fatchat commented 1 year ago

this is also relevant: https://docs.getdbt.com/reference/resource-configs/severity

fatchat commented 1 year ago
image