DalgoT4D / prefect-proxy

GNU Affero General Public License v3.0
1 stars 7 forks source link

nullptr check #75

Closed fatchat closed 12 months ago

fatchat commented 12 months ago

@Abhishek-N the test results are not going to codecov... maybe because we renamed the github org and now the urls are different? could you have a look please

fatchat commented 12 months ago

@Ishankoradia the change is so small i could force-merge it, but i was wondering how we have not seen this before

no schedule => manual deployment, of which we have plenty

Ishankoradia commented 12 months ago

Yes you are right , we missed it. How come we didn't catch the error or see it before ? It must be throwing a key error right.

Also you can merge the PR, once test cases pass.

I think we missed it because initially we only had scheduled deployments , laster we decided to add dbt run & airbyte sync as manual deployment.

codecov-commenter commented 12 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (9fba87c) 91.29% compared to head (26a9dde) 91.29%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #75 +/- ## ======================================= Coverage 91.29% 91.29% ======================================= Files 2 2 Lines 839 839 ======================================= Hits 766 766 Misses 73 73 ``` | [Files Changed](https://app.codecov.io/gh/DalgoT4D/prefect-proxy/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DalgoT4D) | Coverage Δ | | |---|---|---| | [proxy/main.py](https://app.codecov.io/gh/DalgoT4D/prefect-proxy/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DalgoT4D#diff-cHJveHkvbWFpbi5weQ==) | `89.44% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fatchat commented 12 months ago

@Abhishek-N fixed it, just had to go to app.codecov.io and add the new organization