Rename column does not behave as expected

ashwinit4d commented 1 month ago

Describe the bug A clear and concise description of what the bug is. Rename Column function requires you to Add a column in order to rename it. The initial form values are considered void. Check screenshot

To Reproduce Steps to reproduce the behavior:

Select a table
Select function "Rename Column"
update the column name and the new column name
Can view the error - Atleast one column name to be added
Now Add column
update the column name and new column name
it works

Expected behavior A clear and concise description of what you expected to happen. Once you update the Rename table form (without adding column), it should take the input values and save the operation After the first 3 steps listed above the update function should have worked.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context Add any other context about the problem here.

fatchat commented 1 month ago

hi ashwini could you clarify...

the "steps to reproduce" say that selecting the operation after selecting a source/model will show the error
but in the initial description you mention "initial form values" , what are these? the form loads with no columns selected
in your screenshot it looks like you are trying to rename "MRN" to "MRNO" which somehow triggered the red error message, but some context must be missing because i did basic renaming during the workshop and i know the operation isn't completely broken

you also mentioned "once you update the form" is it possible you initially selected a column to rename, clicked Save, then clicked Back, then clicked Save again? or something like that

ashwinit4d commented 1 month ago

Updated the "steps to reproduce the bug" and the expected behavior

fatchat commented 1 month ago

@mdshamoon wasn't this fixed as part of https://github.com/DalgoT4D/webapp/pull/1075

mdshamoon commented 1 month ago

Yes @fatchat. I think the issue was opened before our deployment this weekend. I just checked and it is fixed now.

fatchat commented 1 month ago

@ashwinit4d can you verify and close if it is fixed thank you

ashwinit4d commented 1 month ago

This is working now.

DalgoT4D / webapp

Rename column does not behave as expected #1099