Embedded Superset - Githubissues

Fetch from /currentuser :

the superset url
the superset login type (username + password / google oauth / [other oauth in future])

If the client is not paying for Superset, these responses will be empty. But in case they are not, then:

Display Superset in a new "Analytics" page

</li> </ul> <p>And for unified login:</p> <ul> <li>if login type is u+p, send u+p to the iframe for the login action</li> <li>if login type is google oauth, send a message to the iframe to click the button</li> </ul> <p>The iframe will contain a JavaScript listener which will</p> <ul> <li>listen for the login message</li> <li>execute the login flow from <a rel="noreferrer nofollow" target="_blank" href="https://github.com/DevDataPlatform/webapp/issues/199">https://github.com/DevDataPlatform/webapp/issues/199</a> if username+password login</li> <li>find the login button and click it if Google OAuth login</li> </ul> <p>Error reporting</p> <ul> <li>None, if the login fails the user will see it on their screen</li> <li>And anyway there's nothing we can do short of showing a redundant "login failed" message above the iframe</li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/vinod-rajasekaran"><img src="https://avatars.githubusercontent.com/u/23266611?v=4" />vinod-rajasekaran</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Fetch from /currentuser :</p> <p>the superset url the superset login type (username + password / google oauth / [other oauth in future])</p> <p><strong>This will be from org API endpoint of current user in future - 0.2/0.3 ?</strong></p> <p>If the client is not paying for Superset, these responses will be empty. But in case they are not, then:</p> <p>Display Superset in a new "Analytics" page</p> <p><strong>If superset is not enabled for org, page should display with message " Superset not Enabled - Call to action button to contact Sales to enable or something like this</strong> </p> <iframe src = superset url> And for unified login: if login type is u+p, send u+p to the iframe for the login action if login type is google oauth, send a message to the iframe to click the button The iframe will contain a JavaScript listener which will **How will we know username and password for user in superset ? ** **If superset is on OAuth, will user need to login now into Google as we are only doing user+password on DDP ?** listen for the login message execute the login flow from https://github.com/DevDataPlatform/webapp/issues/199 if username+password login find the login button and click it if Google OAuth login Error reporting None, if the login fails the user will see it on their screen And anyway there's nothing we can do short of showing a redundant "login failed" message above the iframe </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/fatchat"><img src="https://avatars.githubusercontent.com/u/2160416?v=4" />fatchat</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>we were not able to implement google oauth login inside the iframe</p> <p>so for oauth logins</p> <ul> <li>login in a new window and come back to the iframe</li> </ul> <p>for u+p logins</p> <ul> <li>they can log in inside the iframe - no automatic login at this time, we can do it in a future release</li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Ishankoradia"><img src="https://avatars.githubusercontent.com/u/39583356?v=4" />Ishankoradia</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>superset is embedded. </p> <p>1) for oauth logins users will have to type their u + p and login in to the embed superset.</p> <p>2) for google oauth, we will have a <code>google siginin</code> button on the top/besides the iframe. Users will have to login via the button since oauth doesn't work in iframes. We tried to close the popup window of oauth by using messge and event listeners, however it is not possible to fetch the location of the child window once the user is logged in. Since the child's origin changes from <code>localhost:8088 (superset domain)</code> to <code>accounts.google.com..</code> while signing in, the parent is no longer able to send the message due to a CORS error i.e. the child's popup target origin changed. </p> <p>Parent (webapp)</p> <pre><code>var locationStatusInterval = setInterval(() => { authWindow?.postMessage( { ask: 'locationStatus' }, `${globalContext?.CurrentOrg?.state.viz_url}/#child` ); }, 2000); window?.addEventListener('message', (event) => { console.log('receieved something', event.data); const message = event.data; if ( message?.locationStatus && message.locationStatus === '/superset/welcome/' ) { console.log('asking the window to be closed', message.locationStatus); authWindow?.close(); authWindow = null; clearInterval(locationStatusInterval); } });</code></pre> <p>Child popup (for google oauth) Code for this is in one of the html files of superset.</p> <pre><code>console.log("base layout loaded"); window.addEventListener("message", function (event) { const message = event.data; console.log("someone asked for soemthign"); if (message?.ask === "locationStatus") { console.log("someone asked for locationStatus"); event.source.postMessage({ locationStatus: window.location.pathname }, event.origin); } });</code></pre> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/nairabhishek73"><img src="https://avatars.githubusercontent.com/u/119285990?v=4" />nairabhishek73</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Problems:</p> <ol> <li>Don't show the I frame if the user isn't logged in (if the I frame is shown then the natural next step for the user will be to click on sign in with google)</li> <li>One I login through the popup window the i frame needs to reload and show me superset immediately. (currently no change in. the page till i move to another opage and come back)</li> <li>If they login sucessfully, then make the log in button at the top right disappear.</li> <li>If they log out it should go back to point 1.</li> </ol> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/fatchat"><img src="https://avatars.githubusercontent.com/u/2160416?v=4" />fatchat</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>@nairabhishek73 </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/nairabhishek73"><img src="https://avatars.githubusercontent.com/u/119285990?v=4" />nairabhishek73</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <ol> <li>Its taking a noticeable 3 seconds for the "Google Sign in" (also note there should be a space between Sign and in) option to pop up everytime I go to the Analysis tab. Enough time for me to panic and click elsewhere. This delay applies even to embedded superset after i've logged in.</li> <li>Its loading immediately on our UI once i sign in on the pop up window. That's great.</li> <li>I am not required to login to superset again if I logout from DDP UI and then log back in. This is great.</li> </ol> <p>We could choose to address point 1 now or later(as a separate issue).</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/fatchat"><img src="https://avatars.githubusercontent.com/u/2160416?v=4" />fatchat</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Let’s put in a loading indicator</p> <p>During these three seconds there’s nothing else in the panel right, other than the word “Analysis”?</p> <p>On Fri, 18 Aug 2023 at 4:32 AM, nairabhishek73 <strong><em>@</em></strong>.***> wrote:</p> <blockquote> <ol> <li>Its taking a noticeable 3 seconds for the "Google Sign in" (also note there should be a space between Sign and in) option to pop up everytime I go to the Analysis tab. Enough time for me to panic and click elsewhere. This delay applies even to embedded superset after i've logged in.</li> <li>Its loading immediately on our UI once i sign in on the pop up window. That's great.</li> <li>I am not required to login to superset again if I logout from DDP UI and then log back in. This is great.</li> </ol> <p>We could choose to address point 1 now or later(as a separate issue).</p> <p>— Reply to this email directly, view it on GitHub <a href="https://github.com/DevDataPlatform/webapp/issues/240#issuecomment-1683087249">https://github.com/DevDataPlatform/webapp/issues/240#issuecomment-1683087249</a>, or unsubscribe <a href="https://github.com/notifications/unsubscribe-auth/AAQPOICNJJUHUEDRF3A7JQTXV2PIFANCNFSM6AAAAAA23BEHU4">https://github.com/notifications/unsubscribe-auth/AAQPOICNJJUHUEDRF3A7JQTXV2PIFANCNFSM6AAAAAA23BEHU4</a> . You are receiving this because you modified the open/close state.Message ID: <strong><em>@</em></strong>.***></p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/fatchat"><img src="https://avatars.githubusercontent.com/u/2160416?v=4" />fatchat</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>ok done @nairabhishek73 </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/nairabhishek73"><img src="https://avatars.githubusercontent.com/u/119285990?v=4" />nairabhishek73</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Works. Loading symbol was a great idea.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

DalgoT4D / webapp

Embedded Superset #240