search

DalgoT4D / webapp

GNU Affero General Public License v3.0
8 stars 35 forks source link

Fix: overflowing components when drawer is collapsed #789

Closed Snehil-Shah closed 5 months ago

Snehil-Shah commented 5 months ago

Summary

Before:

image

Test Plan

After:

after_arrow

fatchat commented 5 months ago

oh how interesting... this isn't how it shows on my browser @Ishankoradia do you see the ^ chevrons when the menu is collapsed? without this fix i mean @Snehil-Shah which browser are you using

Snehil-Shah commented 5 months ago

@fatchat I am on chrome, even the links documentation and privacy policy links were overflowing in my case

Ishankoradia commented 5 months ago

This is good catch @Snehil-Shah @fatchat . Although i dont see anything overflowing in my browser (chrome Version 123.0.6312.124 (Official Build) (arm64)). But in the collapsed state, when i hover below to where the privacy policy could have been, i am able to click and open the page. Clearly something is wrong. FYI, this happens on production too.

Snehil-Shah commented 5 months ago

@Ishankoradia Can you confirm if you are able to hover over the not visible arrow keys as well? This PR should fix that. Although I wonder what's causing this discrepancy between my browser and yours...

fatchat commented 5 months ago

how interesting... i'm happy to merge this

@mdshamoon this seems to be a bug for some browsers / browser versions... any comments

Ishankoradia commented 5 months ago

@Ishankoradia Can you confirm if you are able to hover over the not visible arrow keys as well? This PR should fix that. Although I wonder what's causing this discrepancy between my browser and yours...

Yes i am able to hover over the non visible elements.

mdshamoon commented 5 months ago

@fatchat we have browserstack subscription. Its best to check there as well. @Snehil-Shah can you let me know your chrome version?

The changes looks good otherwise.

Snehil-Shah commented 5 months ago

@mdshamoon Weirdly, I don't see the overflowing components anymore in my browser. I assume my Chrome might have updated. But I am still able to hover over the invisible clickables. (without this patch).