search

DalgoT4D / webapp

GNU Affero General Public License v3.0
5 stars 35 forks source link

Sorted streams by alphabetical order and added tests #842

Closed Harine19 closed 1 month ago

Harine19 commented 1 month ago

-> I have added under the "useEffect(()" function to sort the streams by name in alphabetical order -> I have also added the necessary test to check the sorting -> CreateConnectionForm.tsx contains the sorting Thankyou

fatchat commented 1 month ago

thank you for your contribution @Harine19 PR #841 beat you to it though

Harine19 commented 1 month ago

To your kind notice, His pull request did not satisfy all the requirements, please re-check! The auto tests did not finish before mine, it was marked 'X' when I last saw. He had some errors in his code. Mine had the '✔️' emoji before his. Please reconsider..

On Thu, May 2, 2024 at 3:23 PM Rohit K. Chatterjee @.***> wrote:

thank you for your contribution @Harine19 https://github.com/Harine19 PR #841 https://github.com/DalgoT4D/webapp/pull/841 beat you to it though

— Reply to this email directly, view it on GitHub https://github.com/DalgoT4D/webapp/pull/842#issuecomment-2090056449, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXYNRY535OFH52ADG6W3SUTZAIEH7AVCNFSM6AAAAABHCRWT66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJQGA2TMNBUHE . You are receiving this because you were mentioned.Message ID: @.***>

fatchat commented 1 month ago

Your tests had not run when I looked, the workflow was waiting to be approved. His tests ran successfully- I ran them before merging

Also you used a useEffect which I did not understand the need for, his solution to sort a copy of the list in place worked fine