search

DalgoT4D / webapp

GNU Affero General Public License v3.0
5 stars 35 forks source link

Sensible display of pipeline run duration. #857

Closed Pratik-050 closed 1 month ago

Pratik-050 commented 1 month ago

fixes: #854 Sensible display of pipeline run duration.

Adds the time and date format as mentioned in the issue.

Pipeline changes

fatchat commented 1 month ago

Thank you @Pratik-050 . Could you make a change please:

If hours == 0 don't show "0 hr" if hours == 0 and minutes == 0 don't show "0 minutes"

fatchat commented 1 month ago

also please merge in the latest from main thanks

Pratik-050 commented 1 month ago

Made the changes @fatchat! Thanks for the quick response.

New changes are looking like this: PipelineSecondsWithMinutes PipelineOnlySeconds

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 45.01%. Comparing base (a90a630) to head (a6b76ae).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #857 +/- ## ======================================== Coverage 45.01% 45.01% ======================================== Files 76 76 Lines 5247 5247 Branches 1195 1210 +15 ======================================== Hits 2362 2362 + Misses 2879 2754 -125 - Partials 6 131 +125 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.