DalgoT4D / webapp

GNU Affero General Public License v3.0
5 stars 35 forks source link

RBAC invite: Invited user is added directly to user list before accepting invite. #876

Closed nairabhishek73 closed 3 weeks ago

nairabhishek73 commented 1 month ago

https://jam.dev/c/91c2c43b-3990-4204-b0e7-44f88334416c

UI testing org 6 on staging User should be in pending invites

Probably because now this user is already in some list of previous users on staging?

nairabhishek73 commented 1 month ago

Also invited user is able to access the org without acceppting invite.

fatchat commented 1 month ago

@nairabhishek73 this is correct, once an individual has set a login password for Dalgo they never need to do that again

nairabhishek73 commented 1 month ago

Understood. That's fine but if I send an invite then there should be a criteria for the invitee to move from 'pending' to 'user' since this is org specific and not platform specific from the perspective of the person inviting.

They should move from 'pending' to 'user' only after the invitee ID has accessed the org once (via the email link or just opening the platform and seeing the org as an option in their dropdown of list of orgs.)

fatchat commented 1 month ago

the invitee is supposed to get an email telling them they've been added to a new org (and hopefully this happened)

so they get an email and when they log in next the new org appears in their list

there's nothing for them to do. we considered allowing them to reject the invitation but why would they do that this isn't a social site

(this has been standard since september ref https://github.com/DalgoT4D/DDP_backend/issues/324)

nairabhishek73 commented 1 month ago

It informs the inviter of whether or not the invitee has opened the org page since receiving the invite.

fatchat commented 1 month ago

you mean the email tells them whether or not they've accessed that org?

nairabhishek73 commented 2 weeks ago

Yes!