DalgoT4D / webapp

GNU Affero General Public License v3.0
5 stars 35 forks source link

schema name in Transform Page is not editable #895

Closed Abhishek-N closed 1 month ago

Abhishek-N commented 2 months ago

Faced issue on STIR, updating the schema name was not possible

fatchat commented 2 months ago

Repo and schema should both be editable... didn't this used to be the case @Ishankoradia ? am i mis-remembering this

Ishankoradia commented 2 months ago

Faced issue on STIR, updating the schema name was not possible

Hey @fatchat no, i do see some apis in our backend but i dont think we have exposed this functionality of updating Target schem or git repo

fatchat commented 2 months ago

@Ishankoradia ok let's do this then

for the schema do we update DbtCliProfile.target or DbtCliProfile.target_configs.schema or both

Ishankoradia commented 2 months ago

@Ishankoradia ok let's do this then

for the schema do we update DbtCliProfile.target or DbtCliProfile.target_configs.schema or both

Ideally @fatchat we should only be updating DbtCliProfile.target_configs.schema but since we have kept both the values same for some reason. So we will need to update both.

This is how the profiles.yml looks like. The dbtrepo.outputs.schema is same as dbtrepo.target and this value is stored in OrgDbt.default_schema.

config: {}
dbtrepo:
  outputs:
    intermediate:
      dbname: ****
      host: localhost
      password: ****
      port: 5432
      schema: intermediate
      threads: 4
      type: postgres
      user: postgres
  target: intermediate

I think its a good point to distinguish them. In our usecase, we wont ever update dbtrepo.target however we have use at many place while executing dbt --target {default_schema} which might need to replaced carefully if we are going to distinguish them. Shouldn't be terrible though.

fatchat commented 1 month ago

@mdshamoon can we block the button with a spinner when the tasks buttons are blocked with a spinner