search

DalgoT4D / webapp

GNU Affero General Public License v3.0
4 stars 33 forks source link

Added edit feature for github URL for transform #897

Closed mdshamoon closed 1 week ago

mdshamoon commented 2 weeks ago

Summary

Added edit feature for github URL for transform

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 59.62%. Comparing base (7f2edfe) to head (d83ae5c).

Files Patch % Lines
src/components/DBT/DBTTransformType.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #897 +/- ## ========================================== + Coverage 59.60% 59.62% +0.01% ========================================== Files 79 79 Lines 5409 5409 Branches 1291 1289 -2 ========================================== + Hits 3224 3225 +1 + Misses 2159 2077 -82 - Partials 26 107 +81 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fatchat commented 2 weeks ago

at initial setup time let's not show the edit button

image
fatchat commented 2 weeks ago

after editing the target schema, the screen needs to be refreshed to reflect the change

fatchat commented 2 weeks ago

after changing the remote github repo url, the backend correctly resets the repo dir and clones the new repo. but something went wrong in sending the celery task id back to the frontend, so when the frontend polled for progress it received a 400 "no such task id"

Redis contained the correct hash-val though... i.e. hget("clone-github-repo-rc-local-airbyte-pos", '<uuid>') contained

b'[{"message": "cloned git repo", "status": "completed"}]'

so either django queried incorrectly or there is a timing issue

mdshamoon commented 1 week ago

@fatchat this is ready for review.