DalgoT4D / webapp

GNU Affero General Public License v3.0
5 stars 35 forks source link

900 schema change detection #904

Closed Abhishek-N closed 1 week ago

Abhishek-N commented 1 month ago

PR: #900

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 23.60515% with 178 lines in your changes missing coverage. Please review.

Project coverage is 57.53%. Comparing base (d179ebc) to head (521e395).

Files Patch % Lines
...components/Connections/SchemaChangeDetailsForm.tsx 7.14% 138 Missing and 5 partials :warning:
src/components/Connections/Connections.tsx 19.23% 20 Missing and 1 partial :warning:
src/components/Connections/PendingActions.tsx 75.51% 12 Missing :warning:
src/components/DBT/DBTTransformType.tsx 0.00% 1 Missing :warning:
src/components/UI/Menu/Menu.tsx 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #904 +/- ## ========================================== - Coverage 58.97% 57.53% -1.44% ========================================== Files 80 82 +2 Lines 5545 5777 +232 Branches 1315 1360 +45 ========================================== + Hits 3270 3324 +54 - Misses 2158 2330 +172 - Partials 117 123 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fatchat commented 4 weeks ago
fatchat commented 2 weeks ago

tested on SHRI (production) where the tables have new columns

our UI shows the new columns but it also thinks the tables are new:

image
fatchat commented 2 weeks ago

nice, final step is to use a websocket to check for changes, since the request times out if there are several streams