DalgoT4D / webapp

GNU Affero General Public License v3.0
5 stars 35 forks source link

Frontend on docker #909

Closed yvonnegitau closed 3 weeks ago

yvonnegitau commented 1 month ago

Summary

The goal of this task is to containerise the webapp. This will make it easier for developers to set up the webapp and also maintain the same environment. One change added to the application is the standalone feature. The reason behind this is to make the docker image smaller since we now do not need the node_modules after building the application. We need to make sure none of the functionalities are affected outside docker.

Test Plan

Tested that the webapp starts and can connect to the Backend.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.15%. Comparing base (d4af073) to head (2822253).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #909 +/- ## ======================================= Coverage 59.15% 59.15% ======================================= Files 79 79 Lines 5438 5438 Branches 1299 1282 -17 ======================================= Hits 3217 3217 - Misses 2111 2195 +84 + Partials 110 26 -84 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fatchat commented 3 weeks ago

Thank you @yvonnegitau . Noticed that ENV NEXT_TELEMETRY_DISABLED=1 appears three times in the Dockerfile, is this intended?

fatchat commented 3 weeks ago

yes this works, i had to pass my --env-file to the docker compose command to get the required vars. have updated the README file

i also updated the readme to use docker compose instead of docker-compose. the installation instructions you linked are still valid i.e. they install docker compose v2