search

DalgoT4D / webapp

GNU Affero General Public License v3.0
5 stars 35 forks source link

Next js v14 update #921

Closed mdshamoon closed 3 weeks ago

mdshamoon commented 3 weeks ago

Summary

Next js v14 update

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.25%. Comparing base (177bf8b) to head (03d6f16).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #921 +/- ## ======================================= Coverage 59.25% 59.25% ======================================= Files 80 80 Lines 5468 5468 Branches 1309 1292 -17 ======================================= Hits 3240 3240 - Misses 2116 2200 +84 + Partials 112 28 -84 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Ishankoradia commented 3 weeks ago

@mdshamoon should we release this on staging for a 1-2 days before merging?

mdshamoon commented 3 weeks ago

@Ishankoradia makes sense. Lets do this today.

Ishankoradia commented 3 weeks ago

@mdshamoon done (on staging). Upraded node to 18.20.3 and corresponding npm to 10.7.0.

Had to delete and re-create the pm2 process for webapp since it was still reading the old nodejs version. Only restarting the process didn't work

Ishankoradia commented 3 weeks ago

@mdshamoon merging this. Updated next on beta also.

fatchat commented 2 weeks ago

@Ishankoradia @mdshamoon when you upgrade things please record the commands you used in the ticket

on production i ran nvm install 18.20.3 which upgraded npm to 10.7.0

pm2 was using the 18.16 so i added interpreter: "/home/ddp/.nvm/versions/node/v18.20.3/bin/node" to the top of the ecosystem.config.js file

before that i ran yarn global add pm2@latest and pm2 update which had no effect that i could see

when versions change please also update platform-infra: https://github.com/DalgoT4D/platform_infra/issues/38

Ishankoradia commented 2 weeks ago

@Ishankoradia @mdshamoon when you upgrade things please record the commands you used in the ticket

on production i ran nvm install 18.20.3 which upgraded npm to 10.7.0

pm2 was using the 18.16 so i added interpreter: "/home/ddp/.nvm/versions/node/v18.20.3/bin/node" to the top of the ecosystem.config.js file

before that i ran yarn global add pm2@latest and pm2 update which had no effect that i could see

when versions change please also update platform-infra: DalgoT4D/platform_infra#38

@fatchat i mentioned in the above comment that I had to delete the pm2 process and create a new one to start the webapp from new node version. pm2 doesn't understand the new version somehow.