search

DalgoT4D / webapp

GNU Affero General Public License v3.0
5 stars 35 forks source link

Added menu for elementary report #935

Closed mdshamoon closed 1 week ago

mdshamoon commented 2 weeks ago

Summary

Remaining:

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 58.97%. Comparing base (b7407da) to head (77673f8).

:exclamation: Current head 77673f8 differs from pull request most recent head 7c0fb1f

Please upload reports for the commit 7c0fb1f to get more accurate results.

Files Patch % Lines
src/components/DBT/Elementary.tsx 0.00% 19 Missing and 2 partials :warning:
src/components/SideDrawer/SideDrawer.tsx 0.00% 6 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #935 +/- ## ========================================== - Coverage 59.18% 58.97% -0.22% ========================================== Files 80 80 Lines 5525 5545 +20 Branches 1312 1316 +4 ========================================== Hits 3270 3270 + Misses 2227 2158 -69 - Partials 28 117 +89 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fatchat commented 2 weeks ago

@mdshamoon to get the report generation time from the dbt/make-elementary-report/ response

https://github.com/DalgoT4D/DDP_backend/pull/660

mdshamoon commented 2 weeks ago

@mdshamoon to get the report generation time from the dbt/make-elementary-report/ response

DalgoT4D/DDP_backend#660

Thanks @fatchat . You also mentioned a regenerate report button and API. Are you going to add that also?

fatchat commented 2 weeks ago

@mdshamoon to get the report generation time from the dbt/make-elementary-report/ response DalgoT4D/DDP_backend#660

Thanks @fatchat . You also mentioned a regenerate report button and API. Are you going to add that also?

yes, will do via another backend PR, probably tomorrow

fatchat commented 2 weeks ago

here it is: https://github.com/DalgoT4D/DDP_backend/pull/662

fatchat commented 2 weeks ago

@mdshamoon

variable is NEXT_PUBLIC_SHOW_ELEMENTARY_MENU or NEXT_SHOW_ELEMENTARY_MENU

should be a top-level menu item, not under "analysis" though you can double-check with nair

mdshamoon commented 2 weeks ago

@mdshamoon

variable is NEXT_PUBLIC_SHOW_ELEMENTARY_MENU or NEXT_SHOW_ELEMENTARY_MENU

should be a top-level menu item, not under "analysis" though you can double-check with nair

Updated the variable, its NEXT_PUBLIC_SHOW_ELEMENTARY_MENU Also made the menu item at top level

fatchat commented 2 weeks ago

very nice, i pushed a minor change. will test against backend once that is merged