search

DalgoT4D / webapp

GNU Affero General Public License v3.0
5 stars 35 forks source link

Updated screen for logs #964

Closed mdshamoon closed 4 days ago

mdshamoon commented 1 week ago

Summary

Updated screen for logs

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 20.61856% with 77 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@123fb62). Learn more about missing BASE report.

Files Patch % Lines
src/components/Connections/ConnectionLogs.tsx 16.66% 64 Missing and 11 partials :warning:
src/components/Connections/Connections.tsx 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #964 +/- ## ======================================= Coverage ? 54.28% ======================================= Files ? 88 Lines ? 6090 Branches ? 1448 ======================================= Hits ? 3306 Misses ? 2636 Partials ? 148 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fatchat commented 1 week ago
  1. from the connections list, "fetch logs" button should say "view history"
  2. while the history is loading put a spinner or a "loading..." message
  3. "description" column in the table should say "logs"
  4. the "records synced" values... can we put commas in i.e. "834,500" instead of "834500"

that's all i have, everything else looks good. next week we'll give it to nair for review