DalgoT4D / webapp

GNU Affero General Public License v3.0
5 stars 35 forks source link

Code refactoring and cleanup #965

Closed mdshamoon closed 4 days ago

mdshamoon commented 1 week ago

Summary

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 77.35849% with 12 lines in your changes missing coverage. Please review.

Project coverage is 53.40%. Comparing base (c0a3323) to head (7813742).

Files Patch % Lines
src/components/SideDrawer/SideDrawer.tsx 0.00% 6 Missing :warning:
src/components/ConfigInput/ConfigInput.tsx 63.63% 4 Missing :warning:
src/components/Destinations/DestinationForm.tsx 93.10% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #965 +/- ## ========================================== - Coverage 54.21% 53.40% -0.81% ========================================== Files 89 87 -2 Lines 6170 6022 -148 Branches 1464 1408 -56 ========================================== - Hits 3345 3216 -129 + Misses 2797 2779 -18 + Partials 28 27 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fatchat commented 4 days ago

in the source creation dialog, if i switch from kobo to surveycto (or from surveycto to kobo) the form crashes

mdshamoon commented 4 days ago

Fixed the issue @fatchat. Also added sidedrawer minimization states on iframe pages