DalgoT4D / webapp

GNU Affero General Public License v3.0
5 stars 35 forks source link

Updated interface for pipeline logs #969

Open mdshamoon opened 2 days ago

mdshamoon commented 2 days ago

Summary

Updated interface for pipeline logs

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 78.37838% with 16 lines in your changes missing coverage. Please review.

Project coverage is 54.70%. Comparing base (b212c4d) to head (5b3620b).

Files Patch % Lines
src/components/Flows/FlowLogs.tsx 76.56% 11 Missing and 4 partials :warning:
src/components/Connections/ConnectionLogs.tsx 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #969 +/- ## ========================================== + Coverage 54.28% 54.70% +0.41% ========================================== Files 88 89 +1 Lines 6090 6135 +45 Branches 1429 1463 +34 ========================================== + Hits 3306 3356 +50 + Misses 2757 2630 -127 - Partials 27 149 +122 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fatchat commented 16 hours ago

the limit parameter seems to be ignored; instead of 10 flow-runs i got 50 which is the limit from get_flow_runs_by_deployment_id

(also offset is being sent but the api doesn't take it)

instead of run.kind can we show run.label? this is what i get:

image

maybe come up with some kind of makeReadable(run.label)