DallasMorningNews / generator-dmninteractives

Yeoman generator for DMN-flavored "interactive" pages
https://www.npmjs.com/package/generator-dmninteractives
10 stars 1 forks source link

Imported modules not polyfill-ing #45

Closed achavez closed 6 years ago

achavez commented 7 years ago

So my understanding of Babel is that with the way we have it setup it should be transpiling all JS features that aren't widely supported, but that seems to not be happening with everything that we need to support IE11.

Example: willie code

Looking at the code for babel-preset-es2015, it doesn't appear that transformation is applied: https://github.com/babel/babel/blob/master/packages/babel-preset-es2015/src/index.js

So I'm wondering if we should consider a different transform. It looks like Symbol is ES2016 or ES6. Searching for babel-preset-es2016 leads to babel-preset-latest which leads to babel-preset-env.

So maybe we should use that?

cc @allanjamesvestal

achavez commented 7 years ago

Maybe we try something like:

$ npm install --save-dev babel-preset-env
  presets: [
    ["env", {
      "targets": {
        "browsers": ["last 2 versions", "ie >= 10"]
      }
    }]
  ]
achavez commented 6 years ago

babel-preset-env is implemented and will be in next release