search

Dallinger / Griduniverse

Welcome to the Griduniverse.
7 stars 3 forks source link

Chat messages are displayed as having come from all players when using webpack dev proxy #146

Open jessesnyder opened 6 years ago

jessesnyder commented 6 years ago

To reproduce:

  1. Start automatic bundle rebuilding: yarn run dev
  2. Configure a game with 3 players (the default) and show_chatroom = true
  3. Start the debug server with the proxy option: dallinger debug --verbose --proxy 6001
  4. Walk all three players through the initial forms until they're in the waiting room, and then the grid
  5. Send a chat message from any player

You will see 3 lines in the chat log, one for each player: screen shot 2017-11-06 at 3 14 58 pm

jessesnyder commented 6 years ago

Assigning to @suchow temporarily for verification and prioritization.

suchow commented 6 years ago

Hm, this must interact with some other settings, because when I use a non-default setup it works as expected:

screenshot 2017-11-06 18 36 18

Trying the default next...

suchow commented 6 years ago

Here's the default, but with show_chatroom = true:

screenshot 2017-11-06 18 44 06
suchow commented 6 years ago

Reassigning to @jessesnyder; can't reproduce this.

jessesnyder commented 6 years ago

Interesting... will try to figure out what accounts for the difference.

jessesnyder commented 6 years ago

@suchow It seems to be a side effect of running with the webpack proxy thing (yarn run dev). When I run without that and connect directly to the Flask server I see the correct behavior. I'll update the ticket description with these details. Might be a hard one to fix.