DaloLorn / Rising-Stars

A large-scale mod for Star Ruler 2.
http://steamcommunity.com/sharedfiles/filedetails/?id=812827373
Other
18 stars 7 forks source link

Propulsion 2 tech has no effect on slipstream FTL method #89

Closed BottledByte closed 1 year ago

BottledByte commented 1 year ago

Propulsion 2 technology states in it's desription that it improves range and duration of slipstream by +20%, but it does not affect slipstream FTL at all.

Found in commit 69c880b8c8fd8a172c85480ed72210b863d932eb

Reproduction steps

  1. Play as a race using Slipstream FTL
  2. Check Slipstream stats
  3. Research Propulsion 2
  4. Slipstream stats remain the same

Additional notes

Thrust2 technology definition in data/research/rising_stars/upgrades/minor/Thrust.txt is missing line AddModifier( SlipstreamFactor(1.2) ).

This bug was introduced long time ago, in commit 0a11c956c3a291c41d1456d4937badf1f388f5f6