search

DaltonPimmel / flexigrid

Automatically exported from code.google.com/p/flexigrid
0 stars 0 forks source link

attributes cellPadding, cellSpacing -> use lowercase #2

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Please change the attribute names in the following code to lowercase

 $(t)
  .show() //show if hidden
  .attr({cellPadding: 0, cellSpacing: 0, border: 0})  //remove padding and
spacing
  .removeAttr('width') //remove width properties
  ;

=> .attr({cellpadding: 0, cellspacing: 0, border:0})

Original issue reported on code.google.com by daniel.s...@gmail.com on 21 Jul 2008 at 4:12

GoogleCodeExporter commented 8 years ago 
I think that would fail jQuery. using lowercase requires that you wrap the 
attribute in double quote first. Plus I 
don't see where the problem is, because i'm pertaining to the object notation 
property and not the attribute of 
what you actually see in the markup.

Original comment by paulo...@gmail.com on 15 Aug 2008 at 10:31

GoogleCodeExporter commented 8 years ago 
I'm using jQuery 1.2.3. In that version the resulting markup is simply wrong
(cellSpacing="0") - which is ignored by FireFox, so there is still the default
cellspacing applied.

I can't really use jQuery 1.2.6 (is it fixed there?). It definitely DOES NOT 
fail.
When setting CSS styles I guess that camel case is needed (because of the "-" 
between
words). I would go for the lowercase version for standard HTML attributes 
anyway.

Original comment by daniel.s...@gmail.com on 18 Aug 2008 at 10:36

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
I'm closing this as Invalid, because the camel-casing is necessary for pre-IE8 
users when jQuery is before version 1.5.2 (see jQuery ticket 
http://bugs.jquery.com/ticket/4978).

If the current code is actually a bug, screenshots or sample code to reproduce 
the problem are necessary.

Original comment by eric.caron on 21 Apr 2011 at 10:42