search

DaltonSW / MVM23

Metroidvania Month 23 - Written in C# Godot 4.0
0 stars 1 forks source link

Add enemy knockback, i-frames, HP #105

Closed rustrix closed 7 months ago

DaltonSW commented 7 months ago

Why does Hit Manager take in the first two params if every instance of it being called passes this to both?

rustrix commented 7 months ago

Why does Hit Manager take in the first two params if every instance of it being called passes this to both?

The first one needs to be a Node2D to call QueueFree and IsQueuedForDeletion on it. I could have added these to IHittable, but those methods don't seem like they belong there. TBH I don't think Stun really belongs on IHittable because not all hittable enemies might be stunnable, but that seems like overkill. I didn't add the IHittable methods as Node2D extensions because that doesn't make sense for all nodes. I couldn't add a common base class (afaik, maybe C# has a fancy feature) for all the enemies because the RandomFlyer is a Node2D but the others are CharacterBody2D.