search

Daltron / NotificationBanner

The easiest way to display highly customizable in app notification banners in iOS
MIT License
4.78k stars 662 forks source link

3.0.2 is not compileable #262

Closed antranapp closed 4 years ago

antranapp commented 4 years ago

Just run carthage update and it doesn't work. I'm using Xcode 11.1.

Screenshot 2019-11-16 at 01 08 04

antranapp commented 4 years ago

It seems that this file UIWindow+orientation.swift is somehow missing when checking out with Carthage.

fredpi commented 4 years ago

Same for me with Xcode 11.2

fredpi commented 4 years ago

Also doesn't work with 3.0.1 – 3.0.0 is the last working release

antranapp commented 4 years ago

I open a PR to fix the issue https://github.com/Daltron/NotificationBanner/pull/263

@Daltron can you take a look if it is ok? I also deleted the BannerAnimation file which seems to be unused.

antranapp commented 4 years ago

@Daltron thank you for merging my PR. Can you create a new tag so that Carthage works again. I'll close this issue afterward then.

antranapp commented 4 years ago

@Daltron could you please create a new tag to include the fix in the PR. The tag 3.0.2 is totally broken now.

notapplicableio commented 4 years ago

This is still broken for me. Any updates?

Thanks for taking the time to fix this @peacemoon

antranapp commented 4 years ago

@CognitiveWin you can point your carthage to "master" to fix the issue. But I still prefer to have a fixed version to avoid any unwanted changes with a moving master.

Daltron commented 4 years ago

Hi all, sorry for the delay! I just pushed a new tag 3.0.3. Please let me know if this resolves the issue. Thank you all for being patient!

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.