Daltron / NotificationBanner

The easiest way to display highly customizable in app notification banners in iOS
MIT License
4.79k stars 663 forks source link

Problem with Swift Package Manager. #278

Closed ghost closed 4 years ago

ghost commented 4 years ago

Hello, I have problems when adding to my project with Swift Package manager, it gives me the following error.

I hope you can help me.

Captura de Pantalla 2020-01-05 a la(s) 17 55 19 Captura de Pantalla 2020-01-05 a la(s) 17 54 50

lvnkmn commented 4 years ago

I'm pretty sure this should be fixed in the latest code that's on the master branch of this repo. Can you try if this issue disappears when using that? If so, it would be a good idea for @cbpowell to create a release using that soon.

cbpowell commented 4 years ago

@lvnkmn hopefully the MarqueeLabel 4.0.1 release fixes it, that adds SPM back in and should also allows older Xcode versions.

lvnkmn commented 4 years ago

For now, this configuration works:

image

~Looking forward to a release of that @cbpowell 🙂~ Looking forward to a release of that @Daltron 🙂

cbpowell commented 4 years ago

@lvnkmn that release is actually already available. Is there anything more required on my end?

lvnkmn commented 4 years ago

This commit in master solves the issue, but hasn't been released yet.

@cbpowell tagging that commit with 3.0.4 would solve our problems

cbpowell commented 4 years ago

Gotcha, I was making sure there’s nothing else needed on the MarqueeLabel side. I can’t help with tagging in this repo.

lvnkmn commented 4 years ago

@cbpowell Ah, didn't know that's your repo. Well in that case, what could also fix current issues is by undeleting the Xcode 11 branch. NotificationBanner 3.0.3 is still pointing to that branch and since that one doesn't exist SPM currently fails when using Symantic versioning.

@Daltron Preferably I hope there will be a 3.0.4 tag for This commit soon (Can be SPM only, so no need for cocoa pod updates).

lvnkmn commented 4 years ago

@cbpowell tagging the latest released commit with xcode11 should also work since tags are also seen as branches in SPM.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically closed due to inactivity.