iPad narrow context landscape mode renders full width

[SalsaShark]

On iPad when using a narrow context (side by side or popover) when in portrait, the banner renders correctly. When in landscape, it appears to always render full-width.

Edit: You can't necessarily see it in that screenshot, but if the landscape view is wider, it is clearly rendering all the contents, just for the full width.

[SalsaShark]

Found it. bannerWidth was using window.width, which in landscape view was actually the full width of the device in portrait, so effectively the height in landscape. Using window.frame.size.width seems to correct this.

    internal func updateBannerPositionFrames() {
        guard let window = appWindow else { return }
        bannerPositionFrame = BannerPositionFrame(bannerPosition: bannerPosition,
                                                  bannerWidth: window.frame.size.width,
                                                  bannerHeight: bannerHeight,
                                                  maxY: maximumYPosition(),
                                                  finishYOffset: finishBannerYOffset(),
                                                  edgeInsets: bannerEdgeInsets)
    }

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically closed due to inactivity.