search

Daltron / NotificationBanner

The easiest way to display highly customizable in app notification banners in iOS
MIT License
4.78k stars 662 forks source link

Hotfix: bannerPositionFrame.startFrame unwrapping crash #299

Closed jasonlagaac closed 4 years ago

jasonlagaac commented 4 years ago

Fixes #286

Issue was being caused in 

private let appWindow: UIWindow? = {
        if #available(iOS 13.0, *) {
            return UIApplication.shared.connectedScenes
                .first { $0.activationState == .foregroundActive }
                .map { $0 as? UIWindowScene }
                .map { $0?.windows.first } ?? UIApplication.shared.delegate?.window ?? nil
        }

        return UIApplication.shared.delegate?.window ?? nil
    }()

Where the final return statement returns nil when UIApplication.shared.delegate?.window is also nil

BukhariMuslim commented 4 years ago

Any update?

sandeep9607 commented 4 years ago

please check this comment by Auther https://github.com/Daltron/NotificationBanner/pull/295#issuecomment-623175359

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically closed due to inactivity.