search

Daltron / NotificationBanner

The easiest way to display highly customizable in app notification banners in iOS
MIT License
4.78k stars 662 forks source link

Turk jk patch 309 #310

Closed turk-jk closed 4 years ago

turk-jk commented 4 years ago

when init the FloatingNotificationBanner without title let banner = FloatingNotificationBanner(title: nil, subtitle: text, titleFont: nil, titleColor: .lightGray, titleTextAlign: .left, subtitleFont: nil, subtitleColor: .black, subtitleTextAlign: .left, leftView: imageView, rightView: nil, style: .info, colors: bannerColors(), iconPosition: .top)

the app crash, and that's because titleLabel get initialised only if title parameter was supplied

the same crash will happen when applyStyling for a NotificationBanner or a GrowingNotificationBanner

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically closed due to inactivity.