search

Daltron / NotificationBanner

The easiest way to display highly customizable in app notification banners in iOS
MIT License
4.78k stars 662 forks source link

Feature/314 add a11y support #323

Closed misteu closed 3 years ago

misteu commented 3 years ago

This Pull request solves: https://github.com/Daltron/NotificationBanner/issues/314

What this does:

Whenever a Banner is shown, a UIAccessibility.Notification will be posted now to make sure that users with enabled VoiceOver will be notified about the banner. It will read the banners title and its subtitle.

How to test?

Enable VoiceOver and trigger a banner.

Here is an example .mov video of the implementation. a11y_banner.mov.zip

misteu commented 3 years ago

Dear maintainers, would be great if you could label this PR with: hacktoberfest-accepted 👍

Daltron commented 3 years ago

@misteu can you please fix the indentation issues with this PR and resubmit? Thanks!

misteu commented 3 years ago

Hi, yes I will do that later today 👍

misteu commented 3 years ago

@Daltron I fixed the indentation for this MR.

Daltron commented 3 years ago

Thanks for doing this @misteu!!