search

Daltron / NotificationBanner

The easiest way to display highly customizable in app notification banners in iOS
MIT License
4.78k stars 662 forks source link

Fix `appWindow` so it returns the correct window #324

Closed michalciurus closed 3 years ago

michalciurus commented 3 years ago

NotificationBanner has stopped working for us. I figured out that the reason was that appWindow is returning a wrong window. This PR fixes it and makes the code a little bit easier to read (UIApplication.shared.windows.filter {$0.isKeyWindow}.first seems clearer)

zippo1111 commented 3 years ago

hello! how did you reproduce this error ?

Daltron commented 3 years ago

@michalciurus there looks like there is a merge conflict that needs to be resolved before I can consider merging this. Would you be able to fix the conflict and retest?

Daltron commented 3 years ago

Actually it looks like this PR is doing the same thing so I am going to close this PR for now. Thanks for contributing! :)