search

Daltron / NotificationBanner

The easiest way to display highly customizable in app notification banners in iOS
MIT License
4.77k stars 660 forks source link

Not possible to call applyStyling on GrowingNotificationBanner before adding to queue #377

Closed FWJonathan closed 2 years ago

FWJonathan commented 2 years ago

If you attempt to call applyStyling with font changes on a GrowingNotificationBanner before adding to the queue, there is a crash on a force unwrap of bannerPosition in onOrientationChanged() (called by updateBannerHeight()).

If you call applyStyling after adding to the queue, it is too late for font changes to be considered when evaluating the banner height.

Perhaps the applyStyling info could be passed into the GrowingNotificationBanner init (similarly to colors). so that the height resolution can be deferred until an appropriate moment.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically closed due to inactivity.

FWJonathan commented 1 year ago

This issue still exists in 3.2.0