search

Daltron / NotificationBanner

The easiest way to display highly customizable in app notification banners in iOS
MIT License
4.75k stars 660 forks source link

Banner top inset fix for dynamic island #395

Closed Maxim-Inv closed 1 year ago

Daltron commented 1 year ago

@Maxim-Inv I really appreciate you doing this! Before I can merge it in, it looks like a few banners are not quite adjusting correctly for the dynamic island. I would recommend going down the line in the example app and making sure all of those work as expected. Could you take a look please? I'll get this merged in asap once we can confirm that all cases have been fixed!

Thank you!! 🙂 🥇

Simulator Screen Shot - iPhone 14 Pro - 2022-09-21 at 09 55 59

Maxim-Inv commented 1 year ago

Ok. I'll try to make it on weekends.

sayler8182 commented 1 year ago

Hi, did you manage to fix this ?

Maxim-Inv commented 1 year ago

Sorry I haven't had time yet

Roger-Blinto commented 1 year ago

A fix and merge of this would be much appreciated.

materik commented 1 year ago

Since there hasn't been any activity on this PR, I created my own: https://github.com/Daltron/NotificationBanner/pull/399

Daltron commented 1 year ago

Going to close this as this should be fixed now that #399 has been merged in.