Make every type work with dynamic island

materik commented 1 year ago

This PR solves the issue with the banners ending up behind the dynamic island. I have tried all on iPhone 14 Pro and Max and also tried it on iPhone 14 to make sure nothing broke.

Things to note:

Not sure the hasDynamicIsland logic is correct. It worked on the different simulators I tried.
Not sure I have manipulated the height and the margins in the right place. Maybe there is a better way to do it.
Not sure the numbers are perfect. Could be some more padding for certain types but not very knowledgable about the project to make it work perfect for all.

Fixes #394

sayler8182 commented 1 year ago

@Daltron could You merge this PR and release new version ?

Daltron commented 1 year ago

Hi @materik, really sorry for the delay but thank you for doing this! Going to merge this is in and put out a new release! 🎉

vivek-mittal commented 1 year ago

@Daltron Hi, what release is this PR part of? I still see the issue in 3.1.0.

Daltron / NotificationBanner

Make every type work with dynamic island #399