search

Daltron / NotificationBanner

The easiest way to display highly customizable in app notification banners in iOS
MIT License
4.78k stars 662 forks source link

Why disallow background color for custom views? #410

Open nathansalaun-sofia opened 1 year ago

nathansalaun-sofia commented 1 year ago

This line https://github.com/Daltron/NotificationBanner/blob/master/NotificationBanner/Classes/BaseNotificationBanner.swift#L194 prevents setting a background color when there is a custom view.

Is there any reason why this is necessary? Or is it just an artificial limitation?

When I remove the guard, the background color still seems to work fine.

reshmaraghu commented 11 months ago

I see a fix was proposed, but not accepted. https://github.com/Daltron/NotificationBanner/pull/341