Daltron / NotificationBanner

The easiest way to display highly customizable in app notification banners in iOS
MIT License
4.75k stars 660 forks source link

App crashes on nil bannerPosition when using `.applyStyling` #413

Open PaulEhrhardt opened 1 year ago

PaulEhrhardt commented 1 year ago

Setting custom title & subtitle fonts using .applyStyling(...) extension forces the lib to update its height via updateBannerHeight(). It then crashes because bannerPosition == nil when a rotation is detected 💣 Happens more often on iPad when resuming activity from the background and the app UI rotates when becoming active again.

I suggest bannerPosition should be treated optional to avoid force unwrapping.

Device: iPad/ iPhone OS: iOS 16.x

PaulEhrhardt commented 1 year ago

Hello, any updates on this?