search

Dalvany / dalvany-image-panel

Image panel for Grafana
MIT License
16 stars 3 forks source link

FR: Use Grafana variables in settings #14

Closed corgan2222 closed 3 years ago

corgan2222 commented 3 years ago

It would be great if we could use variables which are defined in the dashboard settings in the plugins settings. In a dashboard which uses your plugin a lot, and we want to share, it would be much more easy for the user to add the url once in the settings.

This would be great on

Example of heavy use of your plugin: https://forums.unraid.net/topic/96895-ultimate-unraid-dashboard-uud/

Dalvany commented 3 years ago

Hello, thanks for using the plugin. I don't know how to do it but I'll try.

corgan2222 commented 3 years ago

As I also never have developed a grafana plugin, I have no idea. But maybe

is a good starting point.

Thanks a lot and good luck. :)

Dalvany commented 3 years ago

Thanks for all the links ! I'll look into that !

Dalvany commented 3 years ago

It seems simple

corgan2222 commented 3 years ago

Sounds great. Just hit me, if I can test something.

Dalvany commented 3 years ago

I shouldn't have close the issue. I've done it and I try to build release candidate so you can test it and see if it's ok.

Dalvany commented 3 years ago

@corgan2222, I made a prerelease tell me if it's ok.
I already make a PR to made it available through grafana.com because I'm a little bit confuse by the signing plugin workflow.

corgan2222 commented 3 years ago

Hey, sorry I crashed my home lab and can't test ATM. Hope to get everything back2work on the weekend.

Dalvany commented 3 years ago

Hello, sorry to hear that, I hope you didn't loose anything.

corgan2222 commented 3 years ago

no no, nothing lost :)

I tested the new function and it runs great! Thanks a lot! https://i.imgur.com/FYIhZYy.png

Dalvany commented 3 years ago

Great, I'll close this ticket then.