DamascenoRafael / reminders-menubar

Simple macOS menu bar application to view and interact with reminders. Developed with SwiftUI and using Apple Reminders as a source.
GNU General Public License v3.0
2.43k stars 112 forks source link

French Localization #117

Closed Piaziker closed 1 year ago

Piaziker commented 1 year ago

Here's the first attempt at a French Localization

DamascenoRafael commented 1 year ago

Thanks for your contribution @Piaziker 🎉

I don't understand French 🤣 , but could you double-check the translation for newReminderRemoveParsedDateOption?

More context on this: This option will be presented as in the image below, and when enabled the date that the user entered as part of the title will be removed from the title when creating the new reminder. So, for example, if the user types "do something tomorrow" as a new reminder, the app will automatically add the date referring to "tomorrow" and if the option is enabled, the new reminder will be created as "do something".

Screenshot 2023-03-06 at 20 18 57
Piaziker commented 1 year ago

Ok, understood. I have reviewed and adjusted. I also did another pass to make sure the "completed" term was in line with Apple ("terminés" instead of "complétés")

DamascenoRafael commented 1 year ago

Great @Piaziker! Sorry to bother you again about the translation for newReminderRemoveParsedDateOption.

Please let me know if this makes sense or if any adjustments are needed.

Using google translate (which could be completely wrong 😆) the French translation appears as:

"newReminderRemoveParsedDateOption" = "Do not detect date"; (Ne pas détecter la date)

whereas the original english text is:

"newReminderRemoveParsedDateOption" = "Remove parsed date from title";

About the option that this string represents, using the same example I gave earlier, if the user types "do something tomorrow" the app behavior will be:

In both cases the date is recognized and suggested, the only difference is whether the parsed/analyzed date will be removed from the title or not.

Thanks again for the contribution!

Piaziker commented 1 year ago

I understand that. I made this choice because I couldn't arrive at something pleasant. A literal translation would be "Retirer la date détectée dans le titre", which is convoluted. I'm trying something else

DamascenoRafael commented 1 year ago

Thanks for the changes and for the effort to add French as a supported language 👏 It's really not an easy thing to translate, I went through the same thing when translating into Brazilian Portuguese 😆

I'm accepting this PR now, and in the future if you find it necessary we can update some of the texts.