DamascenoRafael / reminders-menubar

Simple macOS menu bar application to view and interact with reminders. Developed with SwiftUI and using Apple Reminders as a source.
GNU General Public License v3.0
2.59k stars 117 forks source link

Time detected is incorrect in certain specific situations (even with auto-detect disabled) v1.20.0 (also existed on previous version) #152

Closed pearresearch closed 1 year ago

pearresearch commented 1 year ago

https://github.com/DamascenoRafael/reminders-menubar/assets/110237207/7f9e9632-ae11-45eb-a498-3b67a6e06bda

The time detected once the first digit is entered is not updated upon entering the second digit. For instance, in the video, my time currently is past 1:00PM on 6th July. Hence, when I attempt to enter a time including 1, it automatically switches to the next day. Both 1:00AM and 1:00PM have passed of July 6.

But this means I cannot enter 10:00 PM ('1' followed be a '0'), since entering 1 automatically throws it to the next day. But I can successfully enter 4:00 PM, since 4 has not passed yet (4:00 AM has passed). I'm not a dev, so I may not be sure how this is interpreted, but I am trying my best to explain in variants through logical understanding.

DamascenoRafael commented 1 year ago

Hey @pearresearch, sorry for taking so long to respond. Thanks for your feedback. About this issue, let me explain what was happening and what I will do to fix it.

We are using Apple's NSDataDetector API to detect date, but we are making some adjustments to the date returned by the API to try to bring a better experience. It turns out that these adjustments bring several edge cases, so I will simplify these adjustments as much as possible to avoid these edge cases.

About the case you recorded on July 6th at 1:01pm:

I know it sounds confusing and I understand that the final experience as you demonstrated is not ideal. I will simplify these adjustments a lot and I believe it will bring a better experience.

I will commit the fix soon and close the issue. This fix will be in the next release! You should see the changes once the next version is released.