search

DamascenoRafael / reminders-menubar

Simple macOS menu bar application to view and interact with reminders. Developed with SwiftUI and using Apple Reminders as a source.
GNU General Public License v3.0
2.4k stars 111 forks source link

Add 'due' option for menubar counter & upcoming reminders #202

Closed yunruse closed 2 months ago

yunruse commented 2 months ago

I prefer when the menubar only alerts me to reminders that are actually due, so I actually pay attention to it :)

So I added the 'Due' option to the menubar counter (and to Upcoming reminders for those who really don't want to see reminders later in the day!)

Pretty simple case of extending the ReminderInterval and RmbMenuBarCounterType enums such that the filter reaches to now rather than the end of the day.

Localization

Two extra strings added:

"showMenuBarDueCountOptionButton" = "Show due count";
"upcomingRemindersDueTitle" = "Due";

and translated into German by myself & into Polish by my friend Felka.

DamascenoRafael commented 2 months ago

@yunruse, thanks for the contribution and for all the details in the PR! 🚀🚀 I'll review it this weekend.

DamascenoRafael commented 2 months ago

Thanks for the addition @yunruse. LGTM! It was clever to use ForEach to display the different counter options.