Skill System Issues - Githubissues

Damian666 / Orion-Plus-Game-Engine

Simple 2D ORPG game engine written in VB.Net.

Other

20 stars 17 forks source link

Skill System Issues #9

Closed Chronos-92 closed 7 years ago

Chronos-92 commented 7 years ago

Currently, the spell system has the following problems, I'll tick the ones I have resolved and add a comment below to the related commit.

[x] Killing an NPC does not actually kill it. (So no loot, exp or quest progress)
[x] Killing a player does not actually kill them.
[x] NPC spells currently do not work, or even block compilation.
[x] Spells do not currently stun players.
[x] Spells do not correctly stun or knock back NPCs.

Chronos-92 commented 7 years ago

Fixed killing NPCs: https://github.com/Chronos-92/Orion-Plus-Game-Engine/commit/c52877ee9cdb4b004e987726efec612912304dc9

Added new problems though, I broke NPC spells as they rely on a method I did not expect them to use. Will look into this.

Chronos-92 commented 7 years ago

Fixed knockback and stun spells, as well as calculating magic resistance for skills hitting players.

https://github.com/Chronos-92/Orion-Plus-Game-Engine/commit/f2ff586fde54b6a95c52157e2668bce50eed62a8

Chronos-92 commented 7 years ago

Fixed spells not killing players. (Have to revisit some parts of this at some point, I made it work. But didn't rewrite everything.)

https://github.com/Chronos-92/Orion-Plus-Game-Engine/commit/fd5a2fe144de1947094c0a94b3ec9d7e864b91c6

Chronos-92 commented 7 years ago

Fixed NPC spells in https://github.com/Chronos-92/Orion-Plus-Game-Engine/commit/21b683dbb24e4fae5c13dce2182e331fab4971e2

Please note that this is not rewritten at all, I've merely made it work with the appropriate methods. (SkillNpc_Effect and SkillPlayer_Effect) rather than PlayerAttackNpc and PlayerAttackPlayer. I'll have to rewrite the entire system at some point, because right now it abuses methods that're not obviously made for it.