Correctly parse errors with context or with fewer newlines

DamienCassou / flycheck-hledger

hledger checker for flycheck

GNU General Public License v3.0

14 stars 6 forks source link

Correctly parse errors with context or with fewer newlines #22

Closed shivjm closed 7 months ago

shivjm commented 7 months ago

I’ve added tests for the two errors I discovered were incorrectly parsed. The rectifications required tweaking the whitespace matched by the error patterns, so I updated any failing tests as well. Everything passes for me at present. Do let me know in case anything isn’t working correctly!

Closes #21

shivjm commented 7 months ago

Thanks for the review. The reason why the test passed in spite of the last pattern not being included is that it matches a subset of the new pattern I added. I’ve therefore now removed the original (narrower) pattern.

shivjm commented 7 months ago

With pleasure! I think it should be fine now. The diff (edit: between the old and rewritten histories) is empty, and I believe the commit messages are correct.