DamienHarper / auditor-bundle

The missing audit log library
MIT License
400 stars 121 forks source link

Add Doctrine DHMiddleware by default #331

Closed dmitryuk closed 2 years ago

dmitryuk commented 2 years ago

Closes https://github.com/DamienHarper/auditor/issues/113

codecov[bot] commented 2 years ago

Codecov Report

Merging #331 (873cfc8) into master (9ad2367) will decrease coverage by 0.52%. The diff coverage is 85.00%.

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   93.22%   92.69%   -0.53%     
==========================================
  Files          15       15              
  Lines         295      315      +20     
==========================================
+ Hits          275      292      +17     
- Misses         20       23       +3     
Impacted Files Coverage Δ
...iler/DoctrineProviderConfigurationCompilerPass.php 89.13% <85.00%> (-3.18%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dmitryuk commented 2 years ago

@DamienHarper I need a new release of https://github.com/DamienHarper/auditor to make test work

DamienHarper commented 2 years ago

@dmitryuk auditor 2.2.0 is released

dmitryuk commented 2 years ago

Tests anyway will throw User Deprecated: The "Symfony\Bridge\Doctrine\Logger\DbalLogger" class implements "Doctrine\DBAL\Logging\SQLLogger" that is deprecated Use {@see \Doctrine\DBAL\Logging\Middleware} or implement {@see \Doctrine\DBAL\Driver\Middleware} instead. because Doctrine anyway defines the doctrine.dbal.logger service and Symfony includes the class to dump container.

But now the error not caused by auditor package and must be resolved outside the package.

image image

PR is ready for review and merge

DamienHarper commented 2 years ago

@dmitryuk Thanks a lot for your hard work

dmitryuk commented 2 years ago

@DamienHarper can you make a release?

DamienHarper commented 2 years ago

@dmitryuk done