Closed dmitryuk closed 2 years ago
Merging #331 (873cfc8) into master (9ad2367) will decrease coverage by
0.52%
. The diff coverage is85.00%
.
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
- Coverage 93.22% 92.69% -0.53%
==========================================
Files 15 15
Lines 295 315 +20
==========================================
+ Hits 275 292 +17
- Misses 20 23 +3
Impacted Files | Coverage Δ | |
---|---|---|
...iler/DoctrineProviderConfigurationCompilerPass.php | 89.13% <85.00%> (-3.18%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@DamienHarper I need a new release of https://github.com/DamienHarper/auditor to make test work
@dmitryuk auditor 2.2.0
is released
Tests anyway will throw User Deprecated: The "Symfony\Bridge\Doctrine\Logger\DbalLogger" class implements "Doctrine\DBAL\Logging\SQLLogger" that is deprecated Use {@see \Doctrine\DBAL\Logging\Middleware} or implement {@see \Doctrine\DBAL\Driver\Middleware} instead.
because Doctrine anyway defines the doctrine.dbal.logger
service and Symfony includes the class to dump container.
But now the error not caused by auditor
package and must be resolved outside the package.
PR is ready for review and merge
@dmitryuk Thanks a lot for your hard work
@DamienHarper can you make a release?
@dmitryuk done
Closes https://github.com/DamienHarper/auditor/issues/113