Closed dmitryuk closed 1 year ago
Merging #133 (3c04c5b) into 2.x (142ca8c) will decrease coverage by
0.73%
. The diff coverage is91.34%
.:exclamation: Current head 3c04c5b differs from pull request most recent head d3de2a8. Consider uploading reports for the commit d3de2a8 to get more accurate results
@@ Coverage Diff @@
## 2.x #133 +/- ##
==========================================
- Coverage 93.05% 92.31% -0.74%
==========================================
Files 44 44
Lines 1526 1510 -16
==========================================
- Hits 1420 1394 -26
- Misses 106 116 +10
Impacted Files | Coverage Δ | |
---|---|---|
src/Configuration.php | 100.00% <ø> (ø) |
|
src/EventSubscriber/AuditEventSubscriber.php | 90.00% <0.00%> (ø) |
|
src/Provider/AbstractProvider.php | 100.00% <ø> (ø) |
|
...Provider/Doctrine/Auditing/Annotation/Security.php | 100.00% <ø> (ø) |
|
...der/Doctrine/Auditing/Event/DoctrineSubscriber.php | 50.00% <ø> (ø) |
|
src/Provider/Doctrine/Auditing/Logger/Logger.php | 0.00% <ø> (ø) |
|
...ctrine/Auditing/Logger/Middleware/DHConnection.php | 100.00% <ø> (ø) |
|
...octrine/Persistence/Event/CreateSchemaListener.php | 87.50% <0.00%> (-3.81%) |
:arrow_down: |
...ctrine/Persistence/Event/TableSchemaSubscriber.php | 100.00% <ø> (ø) |
|
...rine/Persistence/Reader/Filter/DateRangeFilter.php | 81.81% <ø> (ø) |
|
... and 22 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@DamienHarper please take a look, since I have the same issue in the latest release.
Thanks again @dmitryuk for this PR.
I started working on version
3.0.0
inmaster
branch a few days ago (it will drop PHP 7.4 support, Symfony 4.x support etc.)I also created a
2.x
branch since I started working on3.0
so, could you target this PR to2.x
branch please?I'll backport the fix to
master
branch once merged and released as2.3.1
Done
Don't understand why Github workflow not run after push
Don't understand why Github workflow not run after push
Fixed now but CI is failing now
CI should be ok now
Closes #132