search

DamienHarper / auditor

auditor, the missing audit log library
MIT License
164 stars 53 forks source link

Fix isJsonSupported for MariaDB #226

Closed jmsche closed 3 weeks ago

jmsche commented 3 weeks ago

The version_compare() operator argument seems weird, as it should return JSON is supported for MariaDB >= 10.2.7.
Currently it returns the opposite.

Added tests to make sure it works correctly.

DamienHarper commented 3 weeks ago

Thanks for the contribution @jmsche!

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.81%. Comparing base (94e297d) to head (2fc7138). Report is 20 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #226 +/- ## ========================================== - Coverage 97.15% 96.81% -0.34% ========================================== Files 42 42 Lines 1721 1791 +70 ========================================== + Hits 1672 1734 +62 - Misses 49 57 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jmsche commented 3 weeks ago

Thank you for the fast merge :)