DamionGans / ubuntu-wsl2-systemd-script

[Does not work anymore!] Script to enable systemd support on current Ubuntu WSL2 images
1.56k stars 383 forks source link

one-line install #16

Closed danthe1st closed 4 years ago

danthe1st commented 4 years ago

This pull request makes it possible to use systemd by typing just one line of code.

It downloads the install script using curl and pipes it into bash where it gets executed. The script then installs git along with all other dependencies, clones the repository and continues normally.

In order to test it, the command would be curl "https://raw.githubusercontent.com/danthe1st/ubuntu-wsl2-systemd-script/master/ubuntu-wsl2-systemd-script.sh" | bash until this pull request is merged as the script is only available in the fork.

lucyllewy commented 4 years ago

This pattern of curl | bash is a security-vulnerable method. It is not advised to ever curl directly into bash!

DamionGans commented 4 years ago

I agree with @diddledan. Running scripts directly from internet while they can change at any time seems like a bad idea to me. I don't even trust myself at times. No merge, but thanks a lot for your contribution :)

danthe1st commented 4 years ago

I can fully understand that and I agree with this but I think it should be asded to the README.md that git needs to be installed.

I have tested the systemd install on the Febian distro and it worked after installing git.

DamionGans commented 4 years ago

Good one, will make a PR for that :)