search

DamonOehlman / addressit

Freeform Street Address Parser
https://npm.runkit.com/addressit
93 stars 29 forks source link

Upgrade the Australian postal code regex parser to the stricter one used by Perl's Regex::Common::zip #10

Closed markstos closed 9 years ago

markstos commented 10 years ago

Ref: http://cpansearch.perl.org/src/ABIGAIL/Regexp-Common-2013031301/lib/Regexp/Common/zip.pm

Also, I added some tests with /invalid/ addresses for AU addresses to confirm the behavior in those cases.

DamonOehlman commented 10 years ago

Thanks for this Mark - will merge tonight :)

digitalcraft commented 9 years ago

Damo, can you merge this? We are doing some real-estate apps, this module is gonna get a bit of use.

DamonOehlman commented 9 years ago

Sure thing - if you are going to be doing a bit with it, I should probably add you as a collaborator so you can make sure that stuff that slips through the cracks (like this) get's dealt with.

DamonOehlman commented 9 years ago

Merged and 1.2.0 published to npm. Apologies for the delay on merging this in @markstos

markstos commented 9 years ago

@digitalcraft You might also check out the contact-parser module. I ultimately found it worked better for the mostly-US addresses I was parsing. It's been a while since I switched though, so I'm fuzzy on what the differences were at this point.