search

DamonOehlman / detect-browser

Unpack a browser type and version from the useragent string
MIT License
687 stars 102 forks source link

Add support for Windows CE browsers #156

Closed karpour closed 2 years ago

karpour commented 3 years ago

Windows CE remains used to this day on legacy systems, so adding support for these browsers still makes sense. This PR adds support for all versions of Pocket Internet Explorer, which is included in the ROM of pretty much every Windows CE device, as well as the Japanese NetFront browser, which was also popular on Windows CE, among other portable devices and game consoles.

User Agents used for testing: Microsoft Pocket Internet Explorer/0.6 Mozilla/1.1 (compatible; MSPIE 1.1; Windows CE) Mozilla/1.1 (compatible; MSPIE 2.0; Windows CE) Mozilla/2.0 (compatible; MSIE 3.02; Windows CE) Mozilla/4.0 (compatible; MSIE 4.01; Windows CE) Mozilla/4.0 (compatible; MSIE 4.01; Windows NT Windows CE) Mozilla/4.0 (compatible; MSIE 4.01; Windows NT Windows CE; 800x480) Mozilla/4.0 (compatible; MSIE 5.5; Windows CE) Mozilla/4.0 (compatible; MSIE 6.0; Windows CE) Mozilla/2.0 (compatible; MSInternet Explorer 3.02; Windows CE; 240x320) Mozilla/2.0 (compatible; MSIE 3.02; Windows CE; 240x320) Mozilla/2.0 (compatible; MSIE 3.02; Windows CE; PPC; javascript; 240x320) Mozilla/2.0 (compatible; MSIE 3.02; Windows CE; PPC; 240x320) Mozilla/4.0 (PDA; Windows CE;1.0.0) NetFront/3.0 Mozilla/4.08 (PDA; Windows CE;1.0.0) NetFront/3.1 Mozilla/4.0 (compatible; MSIE 4.01; Windows CE; PPC; 240x320) Mozilla/2.0 (compatible; MSIE 3.02; Windows CE; Smartphone; javascript; ) Mozilla/2.0 (compatible; MSIE 3.02; Windows CE; Smartphone; 176x220) Mozilla/2.0 (compatible; MSIE 3.02; Windows CE; Smartphone; ) Mozilla/4.0 (compatible; MSIE 4.01; Windows CE; Smartphone; 176x220; SPV C500; OpVer 4.1.1.0) Mozilla/4.0 (compatible; MSIE 4.01; Windows CE; Smartphone; 176x220; SPV C500; OpVer 4.1.3.0) Mozilla/4.0 (PDA; Windows CE;0.9.3) NetFront/3.0 Mozilla/4.0 (PDA; Windows CE;1.0.1) NetFront/3.0

DamonOehlman commented 3 years ago

@karpour this looks good to me - happy to add support for those browsers. Prior to merging this in could you remove the package-lock.json file from the PR please? I think if I'm going to add a lock file into the repo to properly support npm locks, then it should probably be done in a separate PR.

karpour commented 3 years ago

Should be good now, package-lock.json is gone.

karpour commented 2 years ago

@DamonOehlman I merged with master and resolved conflicts.

DamonOehlman commented 2 years ago

@karpour - awesome - merging it in.

DamonOehlman commented 2 years ago

And published as 5.3.0