search

DamonOehlman / filestream

W3C File Reader API streaming interfaces
30 stars 11 forks source link

Remove objectMode from FileReadStream #14

Closed feross closed 9 years ago

feross commented 9 years ago

I believe we needed objectMode in the past because the readable stream could emit data that was ArrayBuffer or Uint8Array, etc.

Now that we always emit data as Buffers, objectMode is not necessary.

This PR doesn't change the FileWriteStream case since users might want to push various types (besides strings and Buffers) to the stream.

DamonOehlman commented 9 years ago

Cool - I'll make the same change on the writer also.

DamonOehlman commented 9 years ago

3.0.1 published :)