modernize - Githubissues

DamonOehlman / filestream

W3C File Reader API streaming interfaces

30 stars 11 forks source link

modernize #20

Closed jimmywarting closed 5 years ago

jimmywarting commented 5 years ago

I updated the readable-stream to v3 and they now target node => 6, so i thought we can as well update to more es6 syntax

Removed inherit & xtend dependencies for native alternativ
Use es6 class, const, let
Updated all dependencies
Removed deprecated buffer construction for newer method

DamonOehlman commented 5 years ago

@feross thanks for doing the review and merge - completely lost sight of this one.

@jimmywarting thanks for the PR (apologies for missing it).

feross commented 5 years ago

@DamonOehlman What do you think about just adding standard to this repo to help catch errors? (Since this PR basically converted to StandardJS style)

feross commented 5 years ago

There were basically no code changes required, so I'll just add standard and we can remove it if you disagree. I'm going to publish v5.

feross commented 5 years ago

5.0.0 is published.

DamonOehlman commented 5 years ago

What do you think about just adding standard to this repo to help catch errors? (Since this PR basically converted to StandardJS style)

SGTM, so no need to remove it.