search

DamonOehlman / filestream

W3C File Reader API streaming interfaces
30 stars 11 forks source link

fewer dep #24

Open jimmywarting opened 3 years ago

jimmywarting commented 2 years ago

ping @DamonOehlman

DamonOehlman commented 2 years ago

@jimmywarting Hey mate - thanks for the PR. Haven't forgotten about it.

I guess my initial feedback on this PR is that it's landed with an empty description and looking through the code it's clear that it's not just about fewer deps, so I'm attempting to track through it and understand what is going on. I think it would be great to see smaller targeted PRs for various things. If there's a PR that's focused on removing dependencies, then that's all it should do. If there's a desire to modernise the code my replacing var with const then that's cool too, however, it should be a separate PR also.

DamonOehlman commented 2 years ago

Thanks for raising some of those other issues also - having a look at them now.